Fix S4457 FP: Argument check after async code #6624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| argumentExceptionLocations.Add(node.GetLocation()); | ||
| } | ||
| // "ThrowIfNull" returns void so it cannot be an argument. We can stop. | ||
| else |
There was a problem hiding this comment.
Without this else block, the visit recursion stops for this node.
This means that for something like:
whatever.Invocation()The whatever.Invocation syntax node is not going to keep visiting inside the whatever node, in which case if whatever contains an AwaitExpression, we will not spot it to stop the SyntaxWalker via:
public override void VisitAwaitExpression(AwaitExpressionSyntax node) => keepWalking = false;Which produces this the FP in the testcases.
gregory-paidis-sonarsource
changed the title
analyzers/src/SonarAnalyzer.CSharp/Rules/ParameterValidationInMethodWalker.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ParameterValidationInMethodWalker.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ParameterValidationInMethodWalker.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ParameterValidationInMethodWalker.cs
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Jan 23, 2023
gregory-paidis-sonarsource
force-pushed
the
greg/fix-S4457-FP
branch
from
baa358a
to
97dc7fc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6449