Modify Rule S4018: update rule message to include type inference #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned andrei-epure-sonarsource and unassigned zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource
changed the title
andrei-epure-sonarsource
requested changes
Jan 16, 2023
andrei-epure-sonarsource
assigned zsolt-kolbay-sonarsource and unassigned andrei-epure-sonarsource
github-actions
bot
assigned andrei-epure-sonarsource and unassigned zsolt-kolbay-sonarsource
andrei-epure-sonarsource
requested changes
Jan 17, 2023
There was a problem hiding this comment.
could you also please update the RSPEC in this PR?
see Usage 2 in
https://github.com/SonarSource/sonar-dotnet/blob/master/scripts/rspec/README.md#how-to-use
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned andrei-epure-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
assigned andrei-epure-sonarsource and unassigned zsolt-kolbay-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6636
The rule's message and description were too vague. They didn't make it clear that the type parameters need to be used in the argument list in order to enable type inference when the method is called. Those texts in the rule were updated to reflect that.