Fix S2259 FP: Do not track symbol via TryCast #6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
requested changes
Mar 28, 2023
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IOperationExtensions.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.IsNull.cs
Outdated
Show resolved
Hide resolved
.../SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/NullPointerDereference.CSharp8.cs
Outdated
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
feature/SE
branch
from
119d33f
to
ad802d1
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/As
branch
from
aac43e5
to
481494d
Compare
Tim-Pohlmann
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
LGTM, but some UTs are failing. Probably fixed FPs in S3655.
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/As
branch
from
69d772b
to
a6269df
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
pavel-mikula-sonarsource
added a commit
that referenced
this pull request
Mar 31, 2023
pavel-mikula-sonarsource
added a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6986