Fix S3900 and S2259 FN: Support method dereference #7011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned pavel-mikula-sonarsource
zsolt-kolbay-sonarsource
approved these changes
Mar 31, 2023
|
|
||
| public void WithDelegate(object asParameter, object asVariable) | ||
| { | ||
| if(asParameter == null) |
There was a problem hiding this comment.
[Educational] How is checking for null sets the null state for these variables? Shouldn't S2259 only raise an issue if it's certain that the variable null when it's being dereferenced? Shouldn't it be like this:
if(asParameter == null)
{
SomeAction(asParameter.ToString); // Noncompliant
}
There was a problem hiding this comment.
if(asParameter=null) {
// Here, we're certain that asParametr has Null
} else {
// Here, we're certain that asParamet has NotNull. Even when it's empty.
}
// Here, we will arrive twice: Once asParametr=Null, once asParametr=NotNull
More user-likely scenario is
if(arg !=null) {
DoSomething(arg.ToString)
} else {
// And here, we're sure arg==Null. Even if the `else` is not present, such state is possible
}
arg.ToString(); // Noncompliant, this should have been in the "if" branch. We arrive twice here.
pavel-mikula-sonarsource
force-pushed
the
feature/SE
branch
from
d1fa962
to
d6211d9
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE/S3900-Delegates
branch
from
1023f38
to
7d50545
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6997
There will be a rebase conflict with #7004 refactoring.