New rule S6603: The collection-specific "TrueForAll" method should be used instead of the "All" extension #7163
Conversation
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\Configuration\MapperConfiguration.cs", | ||
| "region": { | ||
| "startLine": 473, |
There was a problem hiding this comment.
| "id": "S6603", | ||
| "message": "The collection-specific "TrueForAll" method should be used instead of the "All" extension", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\Execution\ObjectFactory.cs", |
There was a problem hiding this comment.
| "id": "S6603", | ||
| "message": "The collection-specific "TrueForAll" method should be used instead of the "All" extension", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs", |
There was a problem hiding this comment.
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy\Security\ClaimsPrincipalExtensions.cs", | ||
| "region": { | ||
| "startLine": 31, |
There was a problem hiding this comment.
| "id": "S6603", | ||
| "message": "The collection-specific "TrueForAll" method should be used instead of the "All" extension", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy\Security\ClaimsPrincipalExtensions.cs", |
There was a problem hiding this comment.
gregory-paidis-sonarsource
requested review from
cristian-ambrosini-sonarsource and
sebastien-marichal
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UseTrueForAll.cs
Outdated
Show resolved
Hide resolved
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S6603
branch
from
b168c4d
to
936ccbd
Compare
| public void UseTrueForAll_CS_Immutable() => | ||
| builderCS.AddPaths("UseTrueForAll.Immutable.cs") | ||
| .AddReferences(MetadataReferenceFacade.SystemCollections) | ||
| .WithOutputKind(OutputKind.DynamicallyLinkedLibrary) |
There was a problem hiding this comment.
Educational: what is the purpose of this?
There was a problem hiding this comment.
I do not have a main or top level statements, I split my logic in classes. So the compiler needs to know that there is no entrypoint for this compilation (aka it's a library).
If I added a single line of code, like: var x = 42; above my code it would work as an executable, but it would not add much to the logic of the testcase.
There was a problem hiding this comment.
Actually, I'm not sure, all of those UTs are running fine without this line. I think you need the "single line of code" only using WithTopLevelStatements where the compiler actually needs an entry point, but I think the functionality you mentioned is the default one
There was a problem hiding this comment.
You are absolutely right, the default behavior of the builder is DynamicLinkedLibrary. I did not see it because before I tried with top level statements, which as you said need at least a line of code. Thanks!
| var nullableMethodBad = DoWork()?.All(x => true); // Noncompliant | ||
| var inlineInitialization = new int[] { 42 }.All(x => true); // Noncompliant | ||
|
|
||
| _ = immutable.Fluent().Fluent().Fluent().Fluent().All(x => true); //Noncompliant |
There was a problem hiding this comment.
Assignments are not needed and IMO they can be removed to visually simplify the tests
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S6603
branch
from
936ccbd
to
985c967
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Fixes #7122