.razor: complexity/cognitive complexity return 0 #7978
Conversation
cristian-ambrosini-sonarsource
requested a review
from costin-zaharia-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned cristian-ambrosini-sonarsource
| if (GeneratedCodeRecognizer.IsRazor(node.SyntaxTree)) | ||
| { | ||
| return new(0, ImmutableArray<SecondaryLocation>.Empty); | ||
| } |
There was a problem hiding this comment.
This will disable also the cognitive complexity rule, not only the metric. This rule is not exclude by: #7879. Could you please check with @csaba-sagi-sonarsource if it makes sense to keep the rule active or not for razor files?
There was a problem hiding this comment.
Personal opinion: If we don't have a reliable count of cognitive complexity for .razor files to be shown in the metrics why would we want a rule that might be raised based on the same flawed logic?
There was a problem hiding this comment.
The rule is computing the complexity at the function level. For this kind of limited scope, the precision is better. Please check with @csaba-sagi-sonarsource as he has investigated this already.
There was a problem hiding this comment.
I've checked with @csaba-sagi-sonarsource and he thinks that the count for the complexity of methods fully declared inside .razor files should be good enough. I changed the implementation to target the metrics only.
| if (GeneratedCodeRecognizer.IsRazor(syntaxNode.SyntaxTree)) | ||
| { | ||
| return new(ImmutableArray<SecondaryLocation>.Empty); | ||
| } |
There was a problem hiding this comment.
Same for cyclomatic complexity.
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned costin-zaharia-sonarsource
cristian-ambrosini-sonarsource
force-pushed
the
cristian/razor-cognitive-complexity
branch
from
5db6b41
to
f4045fa
Compare
cristian-ambrosini-sonarsource
requested a review
from costin-zaharia-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned cristian-ambrosini-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
|
Closing this issue since the computed global cognitive complexity and cyclomatic complexity are correct for .razor files and consider both HTML and C# code. The only question remaining would be if it makes sense to keep S1541 (cyclomatic complexity) and S3776 (cognitive complexity) active. At the moment they are both NOT raising for HTML code (everything that is inside the |
cristian-ambrosini-sonarsource
deleted the
cristian/razor-cognitive-complexity
branch
Part of #7936