-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate S6803 #9189
Merged
Merged
Deprecate S6803 #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
added
Type: Improvement
Area: C#
C# rules related issues.
labels
Apr 23, 2024
Closed
mary-georgiou-sonarsource
force-pushed
the
mary/deprecate-S6803
branch
from
April 23, 2024 15:03
47fa064
to
7764bf0
Compare
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned mary-georgiou-sonarsource
Apr 23, 2024
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
costin-zaharia-sonarsource
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned costin-zaharia-sonarsource
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S6803
rspec update: SonarSource/rspec#3910
After discussing the impact of this rule we decided to deprecate it.
The rule applies < .NET8
It has a very low impact
It applies only to sealed components