VSTS-268 Bundle and tree-shake extension task code #365
Conversation
7PH
force-pushed
the
task/br/vsts-268-reduce-extension-size
branch
3 times, most recently
from
98478dc
to
9701128
Compare
7PH
force-pushed
the
task/br/vsts-268-reduce-extension-size
branch
2 times, most recently
from
e5384bf
to
c8eaec7
Compare
| /** | ||
| * Hotfix for shelljs dependency | ||
| * @see https://github.com/microsoft/azure-pipelines-task-lib/issues/942#issuecomment-1904939900 | ||
| */ | ||
| const createShellJsDummyFile = gulpFile("index.js", "", { src: true }).pipe( | ||
| gulp.dest(path.join(outPath, "node_modules", "shelljs")), | ||
| ); | ||
| streams.push(createShellJsDummyFile); |
There was a problem hiding this comment.
shelljs doesn't support being bundled through esbuild, but is imported by the azure task lib. Without this fix, we can build but the task execution fails at runtime because the azure task lib always require shelljs, even though we are not using any exported function which uses this dependency.
More explanation in this POC I made to reproduce the behavior, issue and workaround
There was a problem hiding this comment.
we can also include the real shelljs into node_modules. How can we be sure we aren't using it at all on all systems?
I see it referenced inside the task.ts of the lib
https://github.com/microsoft/azure-pipelines-task-lib/blob/7c0de0dba61afb899068c35d88257017bd3b4736/node/task.ts#L2C8-L2C13
If you're confident it isn't used for any platform, I'm okay with stubbing it like this.
There was a problem hiding this comment.
It's not used, if we were using at some point, yes it would fail in QA and production (we should spot it in QA),
I considered adding shelljs but it's 1.7MB in each shipped task, so figured, since it's a workaround anyway we can save 2M * 15 tasks by adding this 0B file.
7PH
force-pushed
the
task/br/vsts-268-reduce-extension-size
branch
from
c8eaec7
to
d4779b1
Compare
7PH
force-pushed
the
task/br/vsts-268-reduce-extension-size
branch
4 times, most recently
from
11d74c8
to
e6db73b
Compare
7PH
force-pushed
the
task/br/vsts-268-reduce-extension-size
branch
from
e6db73b
to
43d4552
Compare
|
Using esbuild to inline all dependencies (and drop
node_modulesfrom task folders)We need to to add a workaround for shelljs because we can not bundle it
Size reduction
Size before this PR, on master branch with V1+V4+V5
Size after this PR
(After rebase with the 2 new versions, V1+V2+V4+V5+V6):
Build time
On my machine, before
After