SLCORE-668: Fix download of sonar-text #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
thahnen
force-pushed
the
fix/tha/SLCORE-668_SonarText
branch
from
6aeaf96
to
4006d04
Compare
thahnen
changed the title
jblievremont
approved these changes
Jan 29, 2024
|
henryju
pushed a commit
that referenced
this pull request
Feb 1, 2024
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
henryju
pushed a commit
that referenced
this pull request
Feb 1, 2024
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
henryju
pushed a commit
that referenced
this pull request
Feb 1, 2024
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
henryju
pushed a commit
that referenced
this pull request
Feb 2, 2024
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
henryju
pushed a commit
that referenced
this pull request
Feb 2, 2024
It wasn't downloaded on SQ 10.4 DEV because it was still concidered to be embedded when the synchonization was happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue that connecting SonarLint to SQ 10.3 and earlier worked the same as before. However, with 10.4, the
sonar-textanalyzer wasn't downloaded anymore because it was still seen as embedded while thePluginsSynchonizerwas synchronizing the plug-ins for the connection.The first approach to mitigate this issue only worked when the connection was established; the IDE was closed and then opened again for the synchronization to start again. This was due to the check to remove the embedded instance of
sonar-textnot being able to access the server information yet to check the SQ version.The synchronization of the SQ server information was not finished the first time, but when the IDE was restarted, the information was already present.
With this PR, the changes are now finally in place to wait for the server information to be synchronized before making the check on SQ 10.4+ (when we don't use the embedded
sonar-textbut rather fetch the one from the server alongsidesonar-text-enterprise) and before handing everything over to thePluginsSynchonizerto synchronize the plug-ins to be downloaded.Testing
Due to SQ 10.4 DEV currently not yet including the new
sonar-textandsonar-text-enterpriseversions, which support SonarLint via the manifest attributes, there are unit as well as medium tests in place to emulate the behavior of having SQ 10.4 and SQ 10.3!Additionally, manual tests were done with the new
sonar-textandsonar-text-enterpriseversions and SQ 10.4 DEV locally, where the plug-ins were exchanged alongside manual testing against SQ 10.3 and SQ 10.2 wheresonar-textwas not to be downloaded but where the embedded one should be used.