Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait to close stdout/err before reporting just to be safe #9

Merged
merged 1 commit into from
Feb 7, 2016
Merged

wait to close stdout/err before reporting just to be safe #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions horenso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,26 @@ func (o *opts) run(args []string) (Report, error) {
done <- struct{}{}
}()

outDone := make(chan struct{})
go func() {
defer stdoutPipe.Close()
defer func() {
stdoutPipe.Close()
outDone <- struct{}{}
}()
io.Copy(os.Stdout, stdoutPipe2)
}()

errDone := make(chan struct{})
go func() {
defer stderrPipe.Close()
defer func() {
stderrPipe.Close()
errDone <- struct{}{}
}()
io.Copy(os.Stderr, stderrPipe2)
}()

<-outDone
<-errDone
err = cmd.Wait()
r.EndAt = now()
ex := wrapcommander.ResolveExitCode(err)
Expand Down