Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prs): add new input to ignore any milestones #610

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Apr 3, 2022

Add the pull-request-ignore-any-milestones input.
Closes #518

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)
  • Contributing implementation have been added/updated (for bugfix/feature)
  • Website documentation have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information


View rendered CONTRIBUTING.md
View rendered README.md
View rendered documentation/docs/03-all-inputs.mdx
View rendered documentation/docs/08-pull-requests/01-inputs/01-all-inputs.mdx
View rendered documentation/docs/08-pull-requests/01-inputs/24-ignore-any-milestones-input.mdx

@C0ZEN C0ZEN added enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master labels Apr 3, 2022
@C0ZEN C0ZEN self-assigned this Apr 3, 2022
@Sonia-corporation-bot Sonia-corporation-bot added documentation 📚 Improvements or additions to documentation test 🧪 Contains a change in a test file website 💻 Improvements or additions to website labels Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #610 (769448b) into develop (06ffbef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #610   +/-   ##
========================================
  Coverage    99.15%   99.15%           
========================================
  Files          125      125           
  Lines         2840     2851   +11     
  Branches       275      277    +2     
========================================
+ Hits          2816     2827   +11     
  Misses          22       22           
  Partials         2        2           
Flag Coverage Δ
integration-issues 73.33% <6.66%> (-0.27%) ⬇️
integration-pull-requests 76.86% <100.00%> (+0.09%) ⬆️
unit 99.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/inputs/pull-requests-inputs.service.ts 100.00% <ø> (ø)
tests/utils/test-default-inputs.ts 100.00% <ø> (ø)
src/core/inputs/inputs.enum.ts 100.00% <100.00%> (ø)
...ing/pull-requests/pull-request-ignore-processor.ts 100.00% <100.00%> (ø)
...ng/pull-requests/pull-request-include-processor.ts 100.00% <100.00%> (ø)

Add the `pull-request-ignore-any-milestones` input.
Closes #518
@codeclimate
Copy link

codeclimate bot commented Apr 3, 2022

Code Climate has analyzed commit 769448b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.7%.

View more on Code Climate.

@C0ZEN C0ZEN merged commit 4933eeb into develop Apr 3, 2022
@C0ZEN C0ZEN deleted the feature/any-pr-milestone branch April 3, 2022 19:54
@Sonia-corporation-bot
Copy link
Contributor

🎉 This PR is included in version 1.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sonia-corporation-bot Sonia-corporation-bot added the released 📦 Added when a Github/npm release was made label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master released 📦 Added when a Github/npm release was made test 🧪 Contains a change in a test file website 💻 Improvements or additions to website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ignore any pull request milestones
2 participants