Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): perform a GraphQL schematics validation before processing #900

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Sep 1, 2022

Closes #855.

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)
  • Contributing implementation have been added/updated (for bugfix/feature)
  • Website documentation have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@C0ZEN C0ZEN self-assigned this Sep 1, 2022
@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stale-docs ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 6:20PM (UTC)

@C0ZEN C0ZEN added enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master labels Sep 1, 2022
@Sonia-corporation-bot Sonia-corporation-bot added the test 🧪 Contains a change in a test file label Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #900 (f7b6df6) into develop (bc27273) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #900   +/-   ##
========================================
  Coverage    99.24%   99.25%           
========================================
  Files          130      131    +1     
  Lines         3175     3216   +41     
  Branches       334      337    +3     
========================================
+ Hits          3151     3192   +41     
  Misses          22       22           
  Partials         2        2           
Flag Coverage Δ
integration-issues 72.48% <0.00%> (ø)
integration-pull-requests 75.58% <0.00%> (ø)
unit 99.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/processing/abstract-logger.ts 100.00% <100.00%> (ø)
src/github/github-schemas.service.ts 100.00% <100.00%> (ø)

This run will check every existing schema to ensure that queries and mutations are valid.
If not, the processing will throw.
This will help us ensure there is no issue and favor a fail-fast approach to fix potential issues ASAP.
Closes #855.
@C0ZEN C0ZEN force-pushed the feature/webhooks-definitions branch from 3da27ac to f7b6df6 Compare September 2, 2022 18:16
@codeclimate
Copy link

codeclimate bot commented Sep 2, 2022

Code Climate has analyzed commit f7b6df6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.7%.

View more on Code Climate.

@C0ZEN C0ZEN merged commit b432a8c into develop Sep 2, 2022
@C0ZEN C0ZEN deleted the feature/webhooks-definitions branch September 2, 2022 18:45
@Sonia-corporation-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sonia-corporation-bot Sonia-corporation-bot added the released 📦 Added when a Github/npm release was made label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 Add a new feature/enhancement released 📦 Added when a Github/npm release was made test 🧪 Contains a change in a test file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] @octokit/webhooks-definitions is now deprecated
2 participants