recovering shouldn't change masking state in a recovered action #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoe
force-pushed
the
masking-state-in-recovering
branch
from
91e1156
to
bec01ea
Compare
|
I just pushed a fix for the masking state issue. |
maoe
changed the title
|
Any opinions? |
|
@maoe Thank you for this and my apologies for the delayed response. It looks good and I will be merging it in shortly. I will have us use it in our own codebase for a little bit before releasing to hackage, but it shouldn't be long now. I am assuming you have been using this modified version without any issues for a while now? |
|
Thanks!
Not really. I'm still using the old version. If you could test this change, that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug report rather than a merge request. I've attached a failing test case to demonstrate the issue.
The problem is that when recovering, the masking state of the retrying action is set to
MaskedInterruptibleeven though the original action has been run inUnmasked. It would be nice if the action retried inUnmaskedstate.EDIT: The failing test output: https://travis-ci.org/Soostone/retry/builds/32917884#L137-L141