Resurrect block authentication #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Hoffman <git@fustrate.com>
Signed-off-by: Steven Hoffman <git@fustrate.com>
|
Ok, I'll take a look. Probably good if @athix signs off as well. |
|
I'll take a look when I get a chance, definitely sounds like a good change to have though. |
|
Any updates on this? |
|
@Fustrate sorry for the delay, this looks super helpful upon further review! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never merged into the old repo, but I still think it's a worthwhile change.
NoamB/sorcery#704
These changes allow a website to tell the difference between a wrong password, a locked account, and an inactive account, so that the user can be sent to a "resend activation" or "unlock account" page when necessary.