Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the docs: multiDrag: false should be multiDrag:true #1597

Closed
kinesias opened this issue Aug 6, 2019 · 3 comments
Closed

Typo in the docs: multiDrag: false should be multiDrag:true #1597

kinesias opened this issue Aug 6, 2019 · 3 comments

Comments

@kinesias
Copy link

kinesias commented Aug 6, 2019

in the docs, there's the line:

new Sortable(el, {
multiDrag: false // Enable the plugin
... }

Isn't the plugin enabled with multiDrag: true ?

@kinesias kinesias changed the title Typo: multiDrag: false should be read :true Typo in the docs: multiDrag: false should be multiDrag:true Aug 6, 2019
@owen-m1
Copy link
Member

owen-m1 commented Aug 6, 2019

It is showing the default value for the option, because it is disabled by default. The comment indicates that the option is for enabling the plugin. I will keep this open because maybe I should change it,

@raimund-schluessler
Copy link

This also got me wondering. And it is the same for the OnSpill and Swap plugin by the way. Maybe just change the comment to // Set to true to enable the plugin, defaults to false

owen-m1 added a commit that referenced this issue Sep 2, 2019
@owen-m1
Copy link
Member

owen-m1 commented Sep 2, 2019

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants