Optimize nearestEmptyInsertDetectEvent callback #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the callback doesn't do anything otherwise anyway
lehni
force-pushed
the
optimize-nearest-empty-insert
branch
from
2d638da
to
058adf1
Compare
|
@owen-m1 thanks for merging! Will there be a new release soon? I would appreciate this fix! |
|
@lehni I will see in a few days about a new release. Thank you for your patience. |
|
@lehni |
This was referenced Sep 23, 2019
elo7-developer
pushed a commit
to elo7/Sortable
that referenced
this pull request
Nov 18, 2019
Runi-c
pushed a commit
to Tupperbox/Sortable
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only install these events on
documentwhiledragElis actually set, since the callback doesn't do anything otherwise anyway. This prevents these callbacks from showing up in performance profiles where they looks like they occupy the CPU at high rates while not actually doing anything.