fix click event for mobile devices and old browser #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added forcePolyfill option. forcePolyfill is made to make cross-browser testing more easy. forcePolyfill provides a reliable, consistent cross-browser Solution for Sortable. forcePolyfill gives us the possibility to change the way "dragged items" lok like.
|
i don't know anything about grunt, i'm sorry. would be a waste of time if i tried to make something happen with it ;) |
modified the private _onMove prototype, so it calls events on it's source Element like it's sibling function _dispatchEvent added the handleMove, which listens to the onMove events to the react mixin
|
also fixed my own issue #407 |
|
I should point out: Line 470 is absolutely optional... i just made it append to the Document Body because it fixed the Bug issued in #387. We can alternatively append a different className to the polyfilled/cloned Element. |
|
Thanks a LOT!! Your commit fixed issues we have with Sortable on both Android and iPhone. I hope it will be merged into the master branch. |
wasn't merging all necessary stuff. now it should be fully functional
| @@ -466,12 +471,28 @@ | |||
| _css(ghostEl, 'position', 'fixed'); | |||
| _css(ghostEl, 'zIndex', '100000'); | |||
|
|
|||
| rootEl.appendChild(ghostEl); | |||
| document.body.appendChild(ghostEl); | |||
There was a problem hiding this comment.
ghostEl should be into rootEl, otherwise we will get the wrong display using CSS:
.root-block .dragged-item {
color: red;
}removed the default behaviour to append the cloned Element to the body. now the cloned Element gets added in the same parent, with the addition of the class defined in options.fallbackClass. added the possibility to change the fallback class. added the possibility to decide wheter the fallback should be cloned into the same parent or to the document's body.
|
Cool! Thanks you. |
RubaXa
added a commit
that referenced
this pull request
Jun 27, 2015
fix click event for mobile devices and old browser
|
Please don't forget, that i haven't minified it... You need to run grunt, if you don't mind. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #411 #250 and #436
as well as #387
and #146 #393
added forcePolyfill option.
Sortable.
lok like.