Quentingodeau feature/autoconfigure add test coverage #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngodeau/kafka-webview into quentingodeau-feature/autoconfiguration
Crim
commented
Jun 19, 2019
| @@ -89,10 +90,12 @@ public String index(final Model model) { | |||
| setupBreadCrumbs(model, null, null); | |||
|
|
|||
| // Retrieve all default formats | |||
| final Iterable<MessageFormat> defaultMessageFormats = messageFormatRepository.findByIsDefaultFormatOrderByNameAsc(true); | |||
| final Iterable<MessageFormat> defaultMessageFormats = | |||
There was a problem hiding this comment.
TODO - write test coverage over new logic
Crim
commented
Jun 19, 2019
| @@ -306,7 +323,7 @@ public String deleteCluster(@PathVariable final Long id, final RedirectAttribute | |||
|
|
|||
| // Retrieve it | |||
| final Optional<MessageFormat> messageFormatOptional = messageFormatRepository.findById(id); | |||
| if (!messageFormatOptional.isPresent() || messageFormatOptional.get().isDefaultFormat()) { | |||
| if (!messageFormatOptional.isPresent() || !MessageFormatType.CUSTOM.equals(messageFormatOptional.get().getMessageFormatType())) { | |||
There was a problem hiding this comment.
TODO add test coverage
Crim
commented
Jun 19, 2019
| * Handles discovery and loading of Deserializers that implement the {@link DeserializerDiscoveryService} interface. | ||
| */ | ||
| @Component | ||
| public class DeserializerDiscoveryManager { |
There was a problem hiding this comment.
TODO add test coverage
Crim
commented
Jun 19, 2019
| @@ -26,6 +26,8 @@ | |||
|
|
|||
| import javax.persistence.Column; | |||
| import javax.persistence.Entity; | |||
| import javax.persistence.EnumType; | |||
There was a problem hiding this comment.
TODO - Add migration script.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.