WIP: Archival Storage and Query #1153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemozerr
commented
Nov 14, 2023
| @@ -59,7 +59,7 @@ impl ExposeRpcMacro { | |||
| impl #impl_generics ::std::clone::Clone for RpcStorage #ty_generics #where_clause { | |||
| fn clone(&self) -> Self { | |||
| Self { | |||
| storage: self.storage.clone(), | |||
| storage: ArchivalStorage::new(self.storage.clone()), | |||
There was a problem hiding this comment.
This line just doesn't work. It's just a leftover from having tried different APIs
|
Closing in favor of: #1170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a WIP attempting to add archival storage query access.
We already have versioning for the StateDB, having queries to archival states of StateDB is quite simple. The big work left here is to add versioning to the NativeDB, which stores items related to Accessory State.