Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation about example setup #202

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Added documentation about example setup #202

merged 2 commits into from
Jun 6, 2024

Conversation

JuanPTM
Copy link
Contributor

@JuanPTM JuanPTM commented Jun 4, 2024

Pull request using local branch instead of fork.

#190

@JuanPTM
Added documentation about example setup
540a3f7 
Signed-off-by: Juan Pedro Torres <juan.torres-munoz@univention.de>
@JuanPTM JuanPTM mentioned this pull request Jun 4, 2024
Closed
@JuanPTM JuanPTM requested a review from maxwolfs June 4, 2024 13:44
maxwolfs
maxwolfs approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now and builds – Thanks!

@maxwolfs maxwolfs merged commit f5a9a73 into main Jun 6, 2024
4 checks passed
@maxwolfs maxwolfs deleted the jtorres/example-setup-doc branch June 6, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwolfs maxwolfs maxwolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuanPTM @maxwolfs