Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : FlattenedProvider misplace,e.g. 110 meybe 1-1-0 or 11-0 #129

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

dishcool
Copy link
Contributor

@dishcool dishcool commented Mar 4, 2019

Fix : FlattenedProvider misplace,e.g. 110 meybe 1-1-0 or 11-0

@codecov-io
Copy link

Codecov Report

Merging #129 into master will decrease coverage by 8.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   82.13%   73.46%   -8.68%     
==========================================
  Files          57       41      -16     
  Lines        2234     1123    -1111     
==========================================
- Hits         1835      825    -1010     
+ Misses        399      298     -101
Impacted Files Coverage Δ
Sources/Provider/FlattenedProvider.swift 92.4% <100%> (ø) ⬆️
CollectionKitTests/WaterfallLayoutSpec.swift
CollectionKitTests/RowLayoutSpec.swift
CollectionKitTests/BasicProviderSpec.swift
Sources/Other/CollectionReloadable.swift
Sources/Other/Deprecated.swift
...ollectionKitTests/ComposedHeaderProviderSpec.swift
CollectionKitTests/CollectionViewSpec.swift
CollectionKitTests/TestUils.swift
Sources/Addon/EmptyStateProvider.swift
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b1131...a2504d8. Read the comment docs.

Copy link
Collaborator

@lkzhao lkzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lkzhao lkzhao merged commit daf0bc3 into SoySauceLab:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants