-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace api field with api_compatibility #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally in favor!
It would require to clearly state that unknown fields are OK. We should also remove the notes about ext_
fields.
14-draft.json
Outdated
"enum": [ | ||
"0.14" | ||
] | ||
"version_compatibility": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative field name proposals:
- "apis"
- "compatible_versions"
I would be up to:
I kinda start to dislike |
I would keep the |
What about |
I would be fine with Since it's a personal thing i would agree if you two agree it the best choice. |
I'd be OK with |
|
This way you can build a spaceapi file that is compatible to multiple versions to make a soft migration to new versions possible.
At least as long you don't need to use fields that exclude each other (e.g. using
hPA
barometer unit in 0.13 vs.hPa
in 0.14).Renamed the field so it won't be incompatible to versions 0.13 and lower.
Not sure if the field should still be required, but that's something we can also discuss later.