-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split CI and publish runs into separate workflows #134
Conversation
a2c6c02
to
59b1e76
Compare
I think the issue was something different: The periodic workflow was shown as stopped in https://github.com/SpaceApi/website/actions/workflows/ci.yml since there was no activity on the repository for 3 months. Can we just remove the scheduled run? I'm not sure what the point of it should be. Or maybe split the ci and publish workflows and only schedule the publish workflow. |
eb7fcf1
to
9033736
Compare
Apparently the branches key must be present.
It doesn't make sense to extract the branch name if we only run on one branch.
c50ed3f
to
eb69a3f
Compare
Master has the separate publish workflow.
Oof, that's the issue... Yeah, I usually click on those links in the nag e-mails, but probably forgot it once. The idea of the scheduled workflow was that containers are re-built regularly (security updates). Not sure how important that is for a static website. |
Looks good to me, thanks! The branch name might still be useful if we want to publish separate branches as separate images, but I guess master is sufficient for now. Note: I'm fairly sure that the first commit is wrong (the branches key is not required AFAIK), but it doesn't hurt to specify it (assuming that it's referring to the PR target). |
Yeah I noticed this as well and reverted the change when splitting the workflows. |
The workflow got completely stopped, since it contains scheduled triggers and there was no activity on the repository for months. By splitting that, we avoid the CI workflow from breaking.