-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements #84
Merged
Merged
Enhancements #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of getting it from content id or content disposition as some of the emails are breaking because they send body with content-id
…m by mail.domain.com with esmtp envelope-from <support@domain.com> id 1jt7Nz-0000Da-by for xyz@domain.com; Wed, 08 Jul 2020 10:33:11 +0000
…id by mail.domain.com with esmtps TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256 envelope-from <local@domain.co.id> id 1jr0oT-0006e6-Mx for local@domain.com; Thu, 02 Jul 2020 15:07:51 +0000
…6 by smtpd.kaskus.co.id Postfix with ESMTP id 8C02C2E063E for <formail@ctemplar.com>; Wed, 8 Jul 2020 18:40:03 +0700 WIB
…om with XMail 1.2 password ESMTP Server id <S000000> for <local@domain.com> from <local@domain.com>; Mon, 6 Jul 2020 01:09:35 +0900
…ught and handled already and we dont even need to parse this header, just stopping some noise in our error logger
… all encoding which are not decoded properly by python
…failing emails and cover most of the cases
…icking Content-Type
…python encoded to keep encodings intact
@fedelemantuano |
The PR look good. I'm looking inside it. |
fedelemantuano
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw-unicode-escape
which leave the message unreadable and makes it some gibberish characters. so when we call get_payload() with decode, we are again checking if Content-Transfer-Encoding was one of the culprits then we decode them again withraw-unicode-escape
so that we get the message as it was sent before sending it to ported_string().We checked the test suite as well added in the library but that test suite just check if email parsing is working fine or not but it does not check if encoding was maintained or not. So test suite is working but emails were left with gibberish characters.
PS: We have been using this library for almost 8-9 months now and it has been great to use. But we were still facing encoding issues so we had to investigate and made some changes to library and we have been using these updates for almost 6-7 months now and now our encoding complaints are reduced by 95%-96% Main problems we were facing with unicode characters and different Content-Type, which is mostly resolved now.