Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay action hanging up workflows #5512

Closed
1 task done
davidbelk opened this issue Jul 12, 2023 · 12 comments
Closed
1 task done

Delay action hanging up workflows #5512

davidbelk opened this issue Jul 12, 2023 · 12 comments
Labels
Fixed in v15.2 Fixed in v16.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@davidbelk
Copy link

davidbelk commented Jul 12, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When we have a delay action start with a workflow, after the first action, the workflow hangs with a message of, "Workflow is delayed".
Screenshot 2023-07-12 at 11 21 08 AM

Expected Behavior

The workflow used to continue to move to the next form after the first form was submitted and the delay ran in the background.

Actual Behavior

The workflow displays, "Workflow is delayed" and does not move to the next form.
Screenshot 2023-07-12 at 11 20 39 AM

Steps to Reproduce

Upload the simple test workflow attached.

Rock Version

15.1

Client Culture Setting

en-US

@JimMichael
Copy link
Collaborator

JimMichael commented Jul 12, 2023

I can confirm this behavior on my 15.1 system.

I wonder if this change introduced this behavior 3442c0c

@JimMichael
Copy link
Collaborator

JimMichael commented Jul 12, 2023

Seems like the Delay action is not just delaying the Form actions within the Activity it lives in, but stops all other Form processing in other activities. It looks like a possible work around (though I still consider the current behavior broken) is to:

  1. Move the Delay activity to the bottom of the workflow
  2. Add a Complete Workflow action to the Test Form 2 activity.

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Jul 12, 2023
@nlBayside
Copy link
Contributor

We're also experiencing this problem with some workflows, but not all. That's interesting that it stops Forms from processing in other Workflow Activities. Thank you for the temporary workaround! Hopefully this gets resolved soon

@nairdo nairdo added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Jul 13, 2023
JimMichael referenced this issue Jul 17, 2023
…on didn't prevent the next action from being activated. This was only an issue on the block and not in the process workflow job. (Fixes #5363)
@adamhann
Copy link
Contributor

If it's helpful, we are experiencing the same thing! Thanks for creating this issue David!

@nathanp
Copy link

nathanp commented Aug 24, 2023

We are on 15.1 and are also having this issue.
Any ETA on 15.2?

@nairdo
Copy link
Member

nairdo commented Aug 28, 2023

@nathanp We're currently in the final week+ of alpha testing for v16.0. We would probably start a shorter v15.2 alpha->beta testing cycle shortly afterwards. I know it sounds a bit backwards (order wise) so you'll have to trust us on this.

@nairdo nairdo removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Aug 28, 2023
ethan-sparkdevnetwork added a commit that referenced this issue Sep 8, 2023
… Delay action in once activity prevented the actions in subsequent activities from running until the delay succeeds. The actions without the delay will now run as expected and the action with the delay will not run until the delay succeeds. (Fixes #5512)"

This reverts commit 2f6dea0.
@nairdo
Copy link
Member

nairdo commented Sep 22, 2023

@nathanp In an effort to better communicate release schedules, we recently created a new Release Roadmap which you can get to from the Release Notes page.

@Luke-Potter
Copy link

@nairdo I know on the roadmap you linked 15.2 is "Near Future". This bug in particular is hitting us pretty hard, do you have any kind of eta on this? I'm trying to decide if I can "live" with this issue or I need to be super proactive & deal with it.

Thanks!

@nairdo
Copy link
Member

nairdo commented Sep 26, 2023

@Luke-Potter We're packing the v15.2 alpha today and should start the alpha testing team tomorrow. Let us know if you (or someone from your team) wants to participate in alpha testing: https://community.rockrms.com/get-involved/role/alpha-beta-testers (Just realize you must not deploy alpha-versions to your production system!)

@andypullen
Copy link

This bug is also hitting us pretty hard. The roadmap is helpful in a way, but doesn't sufficiently say when we can expect the update. I'm trying to weigh whether it would be best to wait (if the release is imminent), manually update WorkflowEntry.ascx.cs, or jump the gun on 16.0... @nairdo can you give us any more info on the release schedule? Thank you!

@chead4
Copy link

chead4 commented Oct 9, 2023

@andypullen v15.2 will be released within the next couple weeks.

@nairdo
Copy link
Member

nairdo commented Oct 11, 2023

@andypullen Andy, @chead4 and I reviewed this situation again yesterday. and we ended up accelerating the release of v15.2 -- so it is available as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.2 Fixed in v16.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests