Tr 2037 Compute msg size after compress #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mccammon
commented
Dec 31, 2019
mccammon
commented
- Compute msg size after compress in extendedSend().
- Fix minor bug where need to compensate for payload size increase after compressing with no compression (~50bytes difference).
added 2 commits
December 31, 2019 12:30
…o compression & re-compute message size after compression of payload
mccammon
commented
Dec 31, 2019
ischer
reviewed
Jan 2, 2020
| /* | ||
| * Max size of message that does not need to be compressed as it can be sent via 1 SQS Operation | ||
| * 64kb => b: (64kb * 1024 bytes = 65536 bytes - 50 bytes = 65486) | ||
| * -50 bytes to compensate for size increase after compressing with no compression level |
There was a problem hiding this comment.
how did we settle on 50 bytes for this buffer?
There was a problem hiding this comment.
Series of test up to 64kb never saw more than 40 bytes added post compression with no compression rate. Added another 10 byte buffer for good measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.