Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vuln packages --dependabot #60

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Conversation

KaranSaini
Copy link
Contributor

Ran npm audit fix to update some vulnerable packages and updated proxy-agent (another vulnerable package --dependabot). Ran tests with the command npm run test and they all passed.

Updating these dependencies and publishing the package should remove pac-resolver dependabot notifications from all the repos depending on this package, once updated.

Sidenote:

  • The trim-newlines package cannot be updated to a non-vulnerable version as it is being used by the xunit-file package which is at version 1.0.0 and has not been updated for the past 5 years.

@tklipa01
Copy link

Could we also fix the vulns related to xunit-file since its high sev? It seems like we can just remove xunit-file, i dont see it being used anywhere.

@KaranSaini
Copy link
Contributor Author

Good catch! I removed xunit-file with the command npm uninstall xunit-file and ran the tests, which all passed as usual.

Copy link

@tklipa01 tklipa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KaranSaini KaranSaini merged commit edd67e6 into main Sep 24, 2021
@KaranSaini KaranSaini deleted the updating-vuln-packages branch September 24, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants