Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-724 Check browser before performing browser specific operations #1018

Merged
merged 2 commits into from
Nov 3, 2021
Merged

UX-724 Check browser before performing browser specific operations #1018

merged 2 commits into from
Nov 3, 2021

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Oct 29, 2021 •
edited
Loading

What Changed

  • Checks if window exists before rendering certain components or running hooks

How To Test or Verify

  • Need to figure out how to verify this easily

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

logansparlin
logansparlin approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jonambas jonambas merged commit 3a6d194 into main Nov 3, 2021
@jonambas jonambas deleted the UX-724 branch November 3, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonambas @logansparlin