Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-345 Support additional ListBox keyboard interactions #651

Merged
merged 3 commits into from
Sep 29, 2020
Merged

UX-345 Support additional ListBox keyboard interactions #651

merged 3 commits into from
Sep 29, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Sep 28, 2020 •
edited
Loading

What Changed

  • Properly tabs through the ListBox - bypassing options
  • Opens the Listbox when focused and pressing arrow up or down
  • Returns focus to the Button when closed

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas changed the title UX-345 UX-345 Support additional ListBox keyboard interactions Sep 28, 2020
logansparlin
logansparlin approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonambas jonambas merged commit 91dd3e5 into main Sep 29, 2020
@jonambas jonambas deleted the UX-345 branch September 29, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonambas @logansparlin