Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-632 convert LabelValue to typescript #936

Merged
merged 1 commit into from
Aug 25, 2021
Merged

UX-632 convert LabelValue to typescript #936

merged 1 commit into from
Aug 25, 2021

Conversation

logansparlin
Copy link
Contributor

What Changed

  • Converts LabelValue to typescript

How To Test or Verify

  • Verify all tests pass
  • Verify libby stories

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas self-requested a review August 25, 2021 12:11
jonambas
jonambas approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@logansparlin logansparlin merged commit 310c478 into main Aug 25, 2021
@logansparlin logansparlin deleted the UX-632 branch August 25, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonambas jonambas jonambas approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logansparlin @jonambas