Issue 16 Adding a base object

[aydrian]

Please look at this carefully. I would like as many eyes on it as possible. I've changed things around. The configuration library is gone. We now have a base client object with contained configs. I used the ExactTarget and Twilio node SDKs as inspiration. I also switched to using the nock library instead of our custom mocks.
Looking for suggestions to resolve this

lib/index.js
  line 22  col 25  This function's cyclomatic complexity is too high. (9)

Once this is in place, I should be able to quickly implement the rest of the APIs.
I appreciate all questions, suggestions, thoughts, limericks, what have you.

[aydrian]

Also, would like to get your thoughts about how we are handling the response from the server in the individual API's. The ones in transmissions were wrapped and sending domains were not. I usually just pass the server response straight through. I want to be consistent with this. Appreciate your thoughts.

[jasonrhodes]

This error might want to mention that options needs to be an object?

[aydrian]

Completely doable. I'm not the best at coming up with error messages. First thought was just to make them all return "seg fault". 😏

[jasonrhodes]

As for cycolmatic complexity, it doesn't look like that method is all that complex... I'd probably start by pulling this out into some kind of options = handleOptions(apiKey, options); type method to see if that helps

node-sparkpost/lib/index.js

Lines 24 to 33 in c748b21

	// only options passed in
	if (typeof apiKey === 'object') {
	options = apiKey;
	this.apiKey = process.env.SPARKPOST_API_KEY;
	} else {
	options = options || {};
	this.apiKey = apiKey || process.env.SPARKPOST_API_KEY;
	}

[jmartin4563]

isn't javascript fun :)

[jmartin4563]

Just wanted to add as a general comment, I've noticed that there's some spacing going inside of function argument declarations, which we don't usually do. Like:

var foo = function( bar, bax, bat ) {
  // does stuff
};

[aydrian]

Sorry, the spacing was beaten into me at my last job.