Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perform_substitution #219

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Add perform_substitution #219

merged 2 commits into from
Nov 8, 2021

Conversation

darrensmith223
Copy link
Contributor

No description provided.

@tuck1s tuck1s self-requested a review November 8, 2021 17:31
tuck1s
tuck1s approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@tuck1s tuck1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on quick eyeballing of how similar options are handled. We really should improve test coverage but that's a separate question.

@tuck1s tuck1s merged commit 3a3514d into SparkPost:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuck1s tuck1s tuck1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrensmith223 @tuck1s