fix Django backend to correctly base64 encode attachments #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransmissions._translate_keys to parse from_email into a dict to avoid a server-side bug parsing the sending domain if there's an at symbol in the from name define str_encoding and make flake8 happy use reconfigure_settings in test_message so that DEFAULT_CHARSET is defined on the settings normalize from_email fixes and flakes add test for unicode attachment in Django backend flakes! fix issue where from apparently doesnt need the address wrapper
|
Thanks for the contribution @pegler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API spec specifies attachments must be base64 encoded. This fixes the SparkPostMessage class to actually base64 attachments as well as an invalid test to verify the data is actually encoded property. This also deals with handling unicode attachments without UnicodeDecodeErrors