Update index.html #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparsh1212
requested changes
Dec 1, 2021
There was a problem hiding this comment.
The solution doesn't seem correct to me. Let me clarify it more.
What we basically want is to re-render the launch component when someone clicks on the "GSoC Analyzer" Header.
To give you a hint on how we can achieve that: Try looking at the states involved in the Home component. You'll notice one state there that is capable of doing exactly what we want here. Try to think about how you can alter it to render the Launch Component.
Sparsh1212
reviewed
Dec 1, 2021
Comment on lines
43
to
48
| work correctly both with client-side routing and a non-root public URL. | ||
| Learn how to configure a non-root public URL by running `npm run build`. | ||
| --> | ||
| <title>GSoC Analyser</title> | ||
| <title href="https://sparsh1212.github.io/gsocanalyze">GSoC Analyser</title> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
Also a general note: We rarely make changes to the index.html file in React. Try not to touch this file unless something really specific has to be done in it which can't be achieved through our custom components.
|
can you check discord now pls
…On Wed, Dec 1, 2021, 23:24 Sparsh Agrawal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In public/index.html
<#41 (comment)>
:
> work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
- <title>GSoC Analyser</title>
+ <title href="https://sparsh1212.github.io/gsocanalyze">GSoC Analyser</title>
</head>
<body>
Also a general note: We rarely make changes to the index.html file in
React. Try not to touch this file unless something really specific has to
be done in it which can't be achieved through our custom components.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWWFSGC5MLRM2E7BSX3FEQLUOZOMTANCNFSM5JCFDGBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.