Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL_LUMINANCE deprecated in OpenGL 4 #3

Closed
SpartanJ opened this issue Nov 8, 2014 · 2 comments
Closed

GL_LUMINANCE deprecated in OpenGL 4 #3

SpartanJ opened this issue Nov 8, 2014 · 2 comments
Labels
bug Something isn't working minor

Comments

@SpartanJ
Copy link
Owner

SpartanJ commented Nov 8, 2014

Original report by Dominic Bowden (Bitbucket: clump, GitHub: clump).

Yo, this wonderful library tries to set a texture format of GL_LUMINANCE/GL_LUMINANCE_ALPHA at line 1613 of SOIL.c. OpenGL 4 completely removed those formats, they don't work anymore.

As far as I can tell the intended replacement is to use GL_RED/GL_RG instead, but these have different behaviour (GL_LUMINANCE feeds vec4(x, x, x, 1) to shaders, GL_RED feeds vec4(x, 0, 0, 1) to shaders).
@SpartanJ
Copy link
Owner Author

SpartanJ commented Nov 8, 2014

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Oh, you're right!

Ok, so i'll replace for >= GL3 contexts GL_LUMINANCE for GL_RED and GL_LUMINANCE_ALPHA for GL_RG.

Thanks for reporting it!

Regards,
Martín

@SpartanJ
Copy link
Owner Author

SpartanJ commented Nov 9, 2014

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Fixed issue #3.

@SpartanJ SpartanJ closed this as completed Nov 9, 2014
@SpartanJ SpartanJ added minor bug Something isn't working labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpartanJ