fix/macos path handling #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
solarispika
commented
Nov 10, 2023
solarispika
commented
- Allocate sufficient buffer for long file paths on macOS
- Fix building tests on macOS using CMake
- Fix compiler warnings
solarispika
force-pushed
the
fix/macos-path-handling
branch
from
79ea8e5
to
8055c64
Compare
solarispika
force-pushed
the
fix/macos-path-handling
branch
from
8055c64
to
a456c08
Compare
SpartanJ
reviewed
Nov 10, 2023
solarispika
commented
Nov 11, 2023
There was a problem hiding this comment.
BTW, there is also a warning when compile with debug config on macOS.
/Users/user/Programming/efsw/src/efsw/WatcherKqueue.cpp:439:14: warning: variable 's_fc' set but not used [-Wunused-but-set-variable]
static long s_fc = 0;
^
1 warning generated.
I am not sure how to fix it in a neat cross platform way without using C++17 [[maybe_unused]] attribute.
Feel free to remove s_fc all-together, simply change the debug message from: efDEBUG( "Started using WatcherGeneric, reached file descriptors limit: %ld. Folders "
"added: %ld\n",
mWatcher->mFileDescriptorCount, s_fc );to efDEBUG( "Started using WatcherGeneric, reached file descriptors limit: %ld.",
mWatcher->mFileDescriptorCount ); |
solarispika
force-pushed
the
fix/macos-path-handling
branch
from
a456c08
to
e91a777
Compare
The previous implementation of FileSystem::precomposeFileName on macOS truncated file paths longer than 255 bytes due to a fixed buffer size of 255 bytes. This could lead to unexpected behavior with long file paths. This change uses CFStringGetMaximumSizeForEncoding to determine the needed buffer size to fully contain the string. This allows handling file paths up to the maximum possible length of LONG_MAX bytes, rather than imposing an arbitrary fixed limit. On the unlikely failure case, it returns empty string rather than truncating the path. This prevents incorrect handling of impractically long paths in the caller.
solarispika
force-pushed
the
fix/macos-path-handling
branch
from
e91a777
to
91b74bd
Compare
solarispika
force-pushed
the
fix/macos-path-handling
branch
from
91b74bd
to
5ffeeef
Compare
SpartanJ
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.