Update WithHeadingFinder.php to fix heading fields for lens exports #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE - This pull request is for the 1.2 branch because I am stuck on Nova 3 in the project I'm working on. The fix should be identical for 1.3 and 2.0 though.
When exporting from a lens, the WithHeaderFinder still uses a normal resource's index fields, instead of the lens fields. Therefore if you have any fields in the lens that are not in the index fields for the normal resource, the heading finder cannot locate them and falls back to the attribute name (eg field_name instead of Field Name)
This pull request simply uses the resourceFields (which are used for the export) to lookup the headings. This doesn't adversely affect a normal resource export because ExportResourceActionRequest uses indexFields in its resourceFields method, and it fixes ExportLensActionRequest to correctly locate the header names.