Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NETCore][Research] research MSBuild Tasks for .NET Core MSBuild #1030

Closed
SabotageAndi opened this issue Feb 16, 2018 · 7 comments
Closed
Labels
.NET Core Support SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team
Milestone

Comments

@SabotageAndi
Copy link
Contributor

Our Generate task also needs to run in the .NET Core MSBuild version.
The current base class AppDomainIsolatedTask is not in .NET Standard/Core.

We need to research how this is now done.

@SabotageAndi
Copy link
Contributor Author

@dasMulli can help us perhaps? Do you know something about this?

@dasMulli
Copy link

[@]AArnott has good isolated task samples at https://github.com/AArnott/Nerdbank.MSBuildExtension/tree/master/src/Nerdbank.MSBuildExtension making use of AssemblyLoadContext on core

@dasMulli
Copy link

oh and current best practice is multi-targeting the tasks to net*;netcoreapp2.0 - not netstandard, because the published output of netstandard may not be runnable (no conflict resolution / trimming needed for loading into netcoreapp)

@SabotageAndi
Copy link
Contributor Author

I found a blogpost how to write such task: http://www.natemcmaster.com/blog/2017/07/05/msbuild-task-in-nuget/

@dasMulli
Copy link

As discussed offline, a sample project file that packs the publish-output (to include all dependency dlls) is dotnet/sdk#1846 (comment)

@SabotageAndi SabotageAndi added the SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team label Mar 1, 2018
@SabotageAndi
Copy link
Contributor Author

research is done. MSBuild Task is implemented

@lock
Copy link

lock bot commented Jul 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
.NET Core Support SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team
Projects
None yet
Development

No branches or pull requests

2 participants