Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SpectralGrid, Model, initialize!, simulation, run! structure #327

Merged
merged 30 commits into from
May 29, 2023
Merged

New SpectralGrid, Model, initialize!, simulation, run! structure #327

merged 30 commits into from
May 29, 2023

Conversation

milankl
Copy link
Member

@milankl milankl commented May 15, 2023

attempt to fix #320

@glwagner you might like this pull request!

@milankl milankl added user interface 🎹 How users use our user interface structure 🏠 Internal structure of the code labels May 15, 2023
@milankl milankl added this to the v0.6 milestone May 15, 2023
@milankl milankl marked this pull request as draft May 15, 2023 17:57
@glwagner
Copy link

😂

I'm not 100% sure but the talk here might be relevant for some background:

https://docs.google.com/presentation/d/1eOZm1TOWQFrRSrNJ7KYmsJR_x1yXQCgr62txRAY3JSE/edit?usp=sharing

with some supporting information in

https://github.com/glwagner/ImprovingScientificSoftware2021-HumanCentricAbstractions

This was referenced May 22, 2023
Closed
Closed
Closed
@navidcy
Copy link
Collaborator

navidcy commented May 24, 2023

I like where this PR is going!

(perhaps the PR title is a bit esoteric and not as descriptive tho...)

@milankl milankl mentioned this pull request May 25, 2023
Merged
@glwagner
Copy link

Right, as much as it massages my ego...

@milankl milankl mentioned this pull request May 26, 2023
Closed
@milankl milankl marked this pull request as ready for review May 27, 2023 00:23
@milankl milankl changed the title Gregification New Model, initialize!, simulation, run! structure May 27, 2023
@milankl milankl changed the title New Model, initialize!, simulation, run! structure New SpectralGrid, Model, initialize!, simulation, run! structure May 27, 2023
@milankl
Copy link
Member Author

milankl commented May 27, 2023

@navidcy do you know why the documentation fails with

ERROR: LoadError: UndefVarError: @kwdef not defined

I probabaly removed all the Base. from Base.@kwdef we had before, but only the Documentation complains about this...

@milankl milankl merged commit 07b6e07 into main May 29, 2023
3 checks passed
@navidcy
Copy link
Collaborator

navidcy commented May 29, 2023

@navidcy do you know why the documentation fails with

ERROR: LoadError: UndefVarError: @kwdef not defined

I probabaly removed all the Base. from Base.@kwdef we had before, but only the Documentation complains about this...

Was this the culprit or you still want me to have a look?

@milankl
Copy link
Member Author

milankl commented May 29, 2023 •
edited

All solved now! Yeah, for some reason the documenter doesn't like @kwdef but requires Base.@kwdef, then I also realised that @with_kw has some features that @kwdef doesn't have (like you can do @assert within) but on the other hand @with_kw doesn't allow const declarations in mutable structs, so we have a mix of the two now 😆

@milankl milankl deleted the mk/types branch May 29, 2023 02:26
@milankl milankl mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
structure 🏠 Internal structure of the code user interface 🎹 How users use our user interface
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Away from monolithic run_speedy()?
3 participants
@milankl @glwagner @navidcy