Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarification for SWE variables #332

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Add clarification for SWE variables #332

merged 2 commits into from
Jun 1, 2023

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented May 24, 2023

No description provided.

@navidcy navidcy added the documentation 📚 Improvements or additions to documentation label May 24, 2023
@navidcy navidcy requested a review from milankl May 24, 2023 22:53
@milankl
Copy link
Member

milankl commented May 25, 2023

Awesome, yes. However, $\zeta = \hat{\mathbf{z}} \cdot (\nabla \times \mathbf{u})$ is also somewhat confusing because $\mathbf{u} = (u,v)$ the horizontal components of velocity always, even in the primitive equation models.

@milankl
Copy link
Member

milankl commented May 25, 2023

I'll start on the documentation once #327 is merged!

@navidcy
Copy link
Collaborator Author

navidcy commented May 25, 2023

Ok! Feel free to close this then!

@milankl milankl merged commit b8a5ef7 into main Jun 1, 2023
@milankl milankl deleted the ncc/swe-vars branch March 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milankl milankl milankl approved these changes

Assignees
No one assigned
Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidcy @milankl