Error Fixes #509
Merged
Error Fixes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes several errors and failed checks that cropped up in the last few commits.
If Microchip is giving us a 403, the link must be alive; let's just assume the link is good if we get 403'd by their anti-bot protection for now.
Missed a directory definition for using the new config file.
|
Okay, so it looks like the compile-sketches action is indeed broken. I will go ahead and open an issue on their repo to see what gives. In the meantime, at least Check Links is working now. EDIT: Looks like the Arduino team fixed things on their end. Compile action is working again. |
Adds this repo's github token to the compile-examples workflow to hopefully get around issues relating to rate limiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several errors and failed checks that cropped up in the last few commits.
As part of this, I have commented back out the AVR EB series in boards.txt as there are no definitions in that file for it yet, and also commented out the
avrdaopti.menu.bootloadermodeoptions for AVR DA as likewise no definitions forbootloadermodeexist yet (which was causing all the AVR DA Optiboot checks to fail).Additionally, this implements a patch for "Check Links" to assume that if Microchip gives us 403 instead of 404, then the URL must therefore be valid even if the anti-bot protection prevents us from seeing the content. It also adds this repository's API key to the compile-examples workflow to hopefully relieve rate-limiting issues while checking pushes and PRs.