You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you join a guild and after that delete your char, When a legit guild member go touch the guild stone (i_guildstone), You will get a critical warning. If you run shard in debug, server just crash.
I think the fix could be done here but I dont know how.
…ssue Sphereserver#971).
When a player is deleted, the ClearPlayer method is called before the character destructor, in this method the m_pPlayer property is set to null and this cause the Guild_Resign method (found in the character destructor) to fail and not deleting the player from the guild.
So i just moved the Guild_Resign method from the destructor to the ClearPlayer method.
drk84
added a commit
to drk84/Source2
that referenced
this issue
Dec 3, 2022
…h. (Issue Sphereserver#971).
When a player is deleted the ClearPlayer method is called and this set the m_pPlayer property to null. When a deleted player is inside a guild, the Guild_Resign method will fail because this method relies upon the m_pPlayer to succeed (and the destructor is called after ClearPlayer).
So i just moved the Guild_Resign method in the ClearPlayer before the m_pPlayer property is set to null.
…h. (Issue #971). (#972)
When a player is deleted the ClearPlayer method is called and this set the m_pPlayer property to null. When a deleted player is inside a guild, the Guild_Resign method will fail because this method relies upon the m_pPlayer to succeed (and the destructor is called after ClearPlayer).
So i just moved the Guild_Resign method in the ClearPlayer before the m_pPlayer property is set to null.
If you join a guild and after that delete your char, When a legit guild member go touch the guild stone (i_guildstone), You will get a critical warning. If you run shard in debug, server just crash.
I think the fix could be done here but I dont know how.
Source-X/src/game/chars/CStoneMember.cpp
Lines 282 to 318 in 3dbb447
I think there 2 bug. One in server where he can scan an invalid UID and one in script where he dont delete invalid member.
The text was updated successfully, but these errors were encountered: