This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
More linting #37
Merged
More linting #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've double-checked on github and it looks like nobody really checks for what the detail of exceptions out of the DSG are. Changing the names of the exceptions (to remove “DataSpecification” as a common name prefix, which was just annoying verbosity) is therefore reasonably safe.
Merged
|
Note that this PR breaks sPyNNaker until the linting-related PR for that is done. (The breakage is due to a change to the name of an exception.) |
Don't warn about coverage of code that shouldn't be executed in the first place!
Pull Request Test Coverage Report for Build 393
💛 - Coveralls |
Fixes bug in execute_set_wr_ptr, which was taking where to move to from the wrong part of the command word in some cases.
write_array can now write all integer and floating point types (would love to have fixed-point types too…)
rowleya
approved these changes
Feb 22, 2018
| @@ -273,7 +272,7 @@ def execute_set_wr_ptr(self, cmd): | |||
| if self.use_src1_reg == 1: | |||
|
|
|||
| # the data is a register | |||
| future_address = self.registers[self.dest_reg] | |||
| future_address = self.registers[self.src1_reg] | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSG's exceptions really don't need to be hugely long; Python really does ultimately know their full names, so putting “
DataSpecification” in each of them is almost always just verbose without being informative. (The only ones with the prefix in the name necessarily would otherwise be calledExceptionorSyntaxError, which are just a bit too generic.)