Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds speed up report #274

Merged
merged 6 commits into from
Feb 28, 2018
Merged

adds speed up report #274

merged 6 commits into from
Feb 28, 2018

Conversation

alan-stokes
Copy link
Contributor

@alan-stokes alan-stokes commented Feb 5, 2018

used for debug when other cores go boom in unsetting the timeouts. this report will be allowing us to determine if the speed up data flowed through the chip.

includes a Spynnaker8 for testing this:
SpiNNakerManchester/sPyNNaker8#111

@alan-stokes alan-stokes added the enhancement This adds a new feature label Feb 5, 2018
@alan-stokes alan-stokes added this to the 5.0.0 milestone Feb 5, 2018
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - before merging, can I check that this is OK to do on each run i.e. would you prefer to have an option to disable this report?

@alan-stokes
Copy link
Contributor Author

good question......... dont see the harm in putting a config param in (par the mounting pile of them). either your welcoem to add it, or itll need to wait till ive finished having my arms deep in data in guts.

Conflicts:
	spinn_front_end_common/interface/buffer_management/buffer_manager.py
	spinn_front_end_common/interface/interface_functions/buffer_manager_creator.py
	spinn_front_end_common/interface/interface_functions/insert_extra_monitor_vertices_to_graphs.py
	spinn_front_end_common/utility_models/data_speed_up_packet_gatherer_machine_vertex.py
	spinn_front_end_common/utility_models/data_speed_up_packete_gatherer_application_vertex.py
@coveralls
Copy link

coveralls commented Feb 28, 2018

Pull Request Test Coverage Report for Build 3427

  • 7 of 32 (21.88%) changed or added relevant lines in 5 files are covered.
  • 106 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 42.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_front_end_common/interface/abstract_spinnaker_base.py 0 1 0.0%
spinn_front_end_common/interface/interface_functions/insert_extra_monitor_vertices_to_graphs.py 0 2 0.0%
spinn_front_end_common/utility_models/data_speed_up_packet_gatherer_machine_vertex.py 5 27 18.52%
Files with Coverage Reduction New Missed Lines %
spinn_front_end_common/utility_models/data_speed_up_packet_gatherer.py 1 64.0%
spinn_front_end_common/utility_models/data_speed_up_packet_gatherer_machine_vertex.py 2 32.21%
spinn_front_end_common/interface/interface_functions/insert_extra_monitor_vertices_to_graphs.py 3 23.73%
spinn_front_end_common/utility_models/reverse_ip_tag_multicast_source_machine_vertex.py 100 27.21%
Totals Coverage Status
Change from base Build 3393: -0.1%
Covered Lines: 3023
Relevant Lines: 7151

💛 - Coveralls

@rowleya
Copy link
Member

rowleya commented Feb 28, 2018

Happy enough with that now...

@rowleya rowleya merged commit 54e704c into master Feb 28, 2018
@rowleya rowleya deleted the speed_up_report branch February 28, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants