Fix wrong validation of threshold

romac · romac · commit 06033f1c0eb2 · 2018-08-13T21:29:39.000+02:00
Fortunately as both MIN_SHARES and MIN_THRESHOLD are both set to 2 in errors.rs,
the typo had no impact on validation correctness.
diff --git a/src/share/validation.rs b/src/share/validation.rs
@@ -83,7 +83,7 @@ pub(crate) fn validate_shares<S: IsShare>(shares: &Vec<S>) -> Result<(u8, usize)
 }
 
 pub(crate) fn validate_share_count(threshold: u8, shares_count: u8) -> Result<(u8, u8)> {
-    if threshold < MIN_SHARES {
+    if threshold < MIN_THRESHOLD {
         bail!(ErrorKind::ThresholdTooSmall(threshold));
     }
     if shares_count > MAX_SHARES {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ pub(crate) fn validate_shares<S: IsShare>(shares: &Vec<S>) -> Result<(u8, usize)`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`pub(crate) fn validate_share_count(threshold: u8, shares_count: u8) -> Result<(u8, u8)> {`
`86`		`- if threshold < MIN_SHARES {`
	`86`	`+ if threshold < MIN_THRESHOLD {`
`87`	`87`	`bail!(ErrorKind::ThresholdTooSmall(threshold));`
`88`	`88`	`}`
`89`	`89`	`if shares_count > MAX_SHARES {`