Remove ShareIdentifierTooBig error and validation

Since id is a `u8` it will never be greater than 255.

Author: psivesely

src/errors.rs

@@ -59,11 +59,6 @@ error_chain! {
             display("The shares are incompatible with each other.")
         }
 
-        ShareIdentifierTooBig(id: u8, n: u8) {
-            description("Share identifier too big")
-            display("Found share identifier ({}) bigger than the maximum number of shares ({}).", id, n)
-        }
-
         MissingShares(provided: usize, required: usize) {
             description("The number of shares provided is insufficient to recover the secret.")
             display("{} shares are required to recover the secret, found only {}.", required, provided)

src/share/validation.rs

@@ -37,10 +37,6 @@ pub(crate) fn validate_shares<S: IsShare>(shares: Vec<S>) -> Result<(u8, Vec<S>)
     for share in shares {
         let (id, threshold) = (share.get_id(), share.get_threshold());
 
-        if id > MAX_SHARES {
-            bail!(ErrorKind::ShareIdentifierTooBig(id, MAX_SHARES))
-        }
-
         if id < 1 {
             bail!(ErrorKind::ShareParsingInvalidShareId(id))
         }