Rustfmt updates + add to Travis #60
Conversation
|
Argh, I did not mean to create a merge commit. Feel free to drop it when you rebase this PR against master. |
Looks like rustfmt has made some improvements recently, so wanted to bring the code up to date.
Items that match the `allow_failures` predicate (right now, just Rust nightly), will still finish, but Travis won't wait for them to report a result if the other builds have already finished.
|
Okay, rebased. I noticed |
Sounds good! You can do it in this PR if you want. |
We don't want rustfmt to match `allow_failures` just because it needs to use nightly, while we do want nightly to match `allow_failures`. Env vars provide a solution.
Some of the dependencies we were installing were not listed on https://github.com/SimonKagstrom/kcov/blob/master/INSTALL.md, and we were missing one dependency that was listed there. When `sudo: true` Travis uses Ubuntu Trusty.
kcov builds its own test executables.
|
Okay, everything is looking good and working how I expected. Going to wait for build job #192.5 to finish, then going to push the final commit. This will be an opportunity to confirm that Travis's cargo cacheing, and the cargo-update tool are working how we expect as well. |
As noted in aeb3906 it is not necessary to build the project before running kcov, but kcov does require a `Cargo.lock` file, which can be generated with `cargo update`.
|
Very nice! Thanks a lot! |
* Update rustfmt compliance Looks like rustfmt has made some improvements recently, so wanted to bring the code up to date. * Add rustfmt to nightly item in Travis matrix * Use Travis Cargo cache * Allow fast_finish in Travis Items that match the `allow_failures` predicate (right now, just Rust nightly), will still finish, but Travis won't wait for them to report a result if the other builds have already finished. * Run kcov in a separate matrix build in Travis * Rework allowed_failures logic We don't want rustfmt to match `allow_failures` just because it needs to use nightly, while we do want nightly to match `allow_failures`. Env vars provide a solution. * Add --all switch to rustfmt Travis * Test building docs in Travis * Use exact Ubuntu dependencies listed for kcov Some of the dependencies we were installing were not listed on https://github.com/SimonKagstrom/kcov/blob/master/INSTALL.md, and we were missing one dependency that was listed there. When `sudo: true` Travis uses Ubuntu Trusty. * No need to build before running kcov kcov builds its own test executables. * Generate `Cargo.lock` w/ `cargo update` before running kcov As noted in aeb3906 it is not necessary to build the project before running kcov, but kcov does require a `Cargo.lock` file, which can be generated with `cargo update`.
I rebased this branch on my
validation-2(#59) already, and can rebase this branch again on themasterof this repo if/when that PR is merged.This PR updates formatting throughout the crate based on the latest Clippy version (as of a few days ago). I think the improvements are good.
I also added Clippy to Travis, and made a few changes that should make the Travis builds go faster, including use of the cache, and
fast_finish, so we don't have to wait for the nightly build to finish to get the overall result, since that build is allowed to fail anyway.