Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto mode in sw_plotspec overrides 'imag' option #172

Closed
Artemkth opened this issue Mar 18, 2024 · 1 comment
Closed

Auto mode in sw_plotspec overrides 'imag' option #172

Artemkth opened this issue Mar 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Artemkth
Copy link

I am unable to turn off plotting imaginary component in the auto mode.
@mducle
Copy link
Member

mducle commented Mar 20, 2024 •
edited
Loading

Thanks for reporting this. Sorry, it's a bug.

If you want to fix it yourself, please change line 315 of sw_plotspec.m from:

            'dashed',false,'title',~pColor,'legend',~pColor,'imag',~pColor,...

to

            'dashed',false,'title',~pColor,'legend',~pColor,'imag',~pColor & param.imag,...

@mducle mducle added the bug Something isn't working label Mar 20, 2024
mducle added a commit that referenced this issue Apr 25, 2024
@mducle
Fix bug where imag always plots in auto mode #172
b6db2bc
@mducle mducle mentioned this issue Apr 25, 2024
Merged
mducle added a commit that referenced this issue May 20, 2024
@mducle
Minor Bugfixes (#180)
3e8b492 
* Fix bug where imag always plots in auto mode #172

* Allow row vector for hkl for single point #179

* Fix inverted user colormap #131

* Refactor sw_plotspec to avoid recursive calls #132

* Add fitspec fixes suggested by K Richardson #98

* Add spinw obj to spec for twin cases in fitspec #158

* Fix spec spinw object issues in fitmode

spinwave() now creates a .obj field regardless
  When fitmode=true, this a barebones struct
  When fitmode=false, this is a full spinw object
Fix issue with sw_plotspec when using fastmode/fitmode
Add basic test for fitspec() to check twins handling

* Fix bug in sw_plotspec 'fastmode' handling

* Fix issues from review. Add change log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mducle @Artemkth