Enable and fix latest pedantic lints

Author: kevmoo

analysis_options.yaml

@@ -932,3 +932,9 @@ linter:
     # reason: Trying to assigning a value to void is an error.
     # 0 issues
     - void_checks
+
+    - camel_case_extensions
+    - omit_local_variable_types
+    - prefer_conditional_assignment
+    - prefer_final_fields
+    - use_function_type_syntax_for_parameters

example/common.dart

@@ -13,8 +13,7 @@ export 'package:github/browser_helper.dart';
 Future<void> initViewSourceButton(String script) async {
   // query the DOM for the view source button, handle clicks
   document.querySelector('#view-source')?.onClick?.listen((_) {
-    final WindowBase popup =
-        window.open('view_source.html?script=$script', 'View Source');
+    final popup = window.open('view_source.html?script=$script', 'View Source');
     String code;
 
     var fetched = false;

example/languages.dart

@@ -42,7 +42,7 @@ void reloadTable({int accuracy = 4}) {
   }
 
   isReloadingTable = true;
-  final String md = generateMarkdown(accuracy);
+  final md = generateMarkdown(accuracy);
   github.misc.renderMarkdown(md).then((html) {
     tableDiv.setInnerHtml(html, treeSanitizer: NodeTreeSanitizer.trusted);
     isReloadingTable = false;
@@ -54,10 +54,10 @@ int totalBytes(LanguageBreakdown breakdown) {
 }
 
 String generateMarkdown(int accuracy) {
-  final int total = totalBytes(breakdown);
+  final total = totalBytes(breakdown);
   final data = breakdown.toList();
 
-  String md = '|Name|Bytes|Percentage|\n';
+  var md = '|Name|Bytes|Percentage|\n';
   md += '|-----|-----|-----|\n';
   data.sort((a, b) => b[1].compareTo(a[1]));
 

example/organization.dart

@@ -24,8 +24,8 @@ Future<void> main() async {
 
 Future<void> loadOrganization(String orgToLoad) async {
   try {
-    final Organization org = await github.organizations.get(orgToLoad);
-    final String html = '''
+    final org = await github.organizations.get(orgToLoad);
+    final html = '''
 <br/>Name: ${org.name}
 <br/>Id: ${org.id}
 <br/>Company: ${org.company}

example/readme.dart

@@ -12,7 +12,7 @@ Future<void> main() async {
   readmeDiv = querySelector('#readme');
   var repo = RepositorySlug('SpinlockLabs', 'github.dart');
   final readme = await github.repositories.getReadme(repo);
-  String markdown = readme.content;
+  var markdown = readme.content;
   if (readme.encoding == 'base64') {
     markdown = String.fromCharCodes(base64.decode(markdown));
   }

example/releases.dart

@@ -24,7 +24,7 @@ void loadReleases() {
         <h1>${release.name}</h1>
       </div>
       ''', treeSanitizer: NodeTreeSanitizer.trusted);
-      final Element rel = releasesDiv.querySelector('#release-${release.id}');
+      final rel = releasesDiv.querySelector('#release-${release.id}');
       void append(String key, String value) {
         if (value == null) {
           return;

example/repos.dart

@@ -42,7 +42,7 @@ List<Repository> _reposCache;
 
 void updateRepos(
   List<Repository> repos, [
-  int compare(Repository a, Repository b),
+  int Function(Repository a, Repository b) compare,
 ]) {
   document.querySelector('#repos').children.clear();
   repos.sort(compare);
@@ -69,7 +69,7 @@ void updateRepos(
   }
 }
 
-void loadRepos([int compare(Repository a, Repository b)]) {
+void loadRepos([int Function(Repository a, Repository b) compare]) {
   final title = querySelector('#title');
   if (title.text.contains('(')) {
     title.replaceWith(HeadingElement.h2()
@@ -90,9 +90,7 @@ void loadRepos([int compare(Repository a, Repository b)]) {
     }
   }
 
-  if (compare == null) {
-    compare = (a, b) => a.name.compareTo(b.name);
-  }
+  compare ??= (a, b) => a.name.compareTo(b.name);
 
   github.repositories.listUserRepositories(user).toList().then((repos) {
     _reposCache = repos;

example/search.dart

@@ -9,7 +9,7 @@ Future<void> main() async {
 }
 
 Future<void> search(_) async {
-  final Stream<CodeSearchResults> resultsStream = github.search.code(
+  final resultsStream = github.search.code(
     val('query'),
     language: val('language'),
     filename: val('filename'),
@@ -28,13 +28,13 @@ Future<void> search(_) async {
   final DivElement resultsDiv = querySelector('#results');
   resultsDiv.innerHtml = '';
 
-  int count = 0;
+  var count = 0;
   await for (final results in resultsStream) {
     count += results.items.length;
     querySelector('#nresults').text =
         '${results.totalCount} result${results.totalCount == 1 ? "" : "s"} (showing $count)';
 
-    for (final CodeSearchItem item in results.items) {
+    for (final item in results.items) {
       final url = item.htmlUrl;
       final path = item.path;
       resultsDiv.append(DivElement()

example/users.dart

@@ -18,7 +18,7 @@ void loadUsers() {
     github.users.getUser(baseUser.login).then((user) {
       final userDiv = DivElement();
 
-      for (int i = 1; i <= 2; i++) {
+      for (var i = 1; i <= 2; i++) {
         userDiv.append(BRElement());
       }
 

example/zen.dart

@@ -3,6 +3,6 @@ import 'common.dart';
 
 Future<void> main() async {
   await initViewSourceButton('zen.dart');
-  final String msg = await github.misc.getZen();
+  final msg = await github.misc.getZen();
   querySelector('#zen').text = msg;
 }