-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.7.10][Feature request] Add NBT support for Extreme Crafting table. #99
Comments
Is this still an issue in the 1.1x versions? |
I found this issue in 1.11 (1.7.10). (Shapeless recipe handler also hasn't this code). |
Have you used the 1.10 & 1.11 versions to see if this is still a thing? Im reasonably sure that the tables support NBT... |
I also don't see code for handling NBT there. You should change this like so:
And the same thing here |
Brandon is fixing this and it shall be in the updated vers for 1.1x soon'ish |
Fixes SpitefulFox#99 https: //github.com/SpitefulFox/Avaritia/commit/6c6503bc23de22d76694763e1b21e38d217f56c3 Co-Authored-By: SpitefulFox <6055143+SpitefulFox@users.noreply.github.com>
Hello. The title says it all. Now Extreme Crafting table (Dire Crafting table) doesn't supports recipes with NBT at all, because all recipe handlers (
ExtremeShapedRecipe
,ExtremeShapedOreRecipe
, ...) just check equality of items and its' damages (and ignore NBT) instead of checking equality of ItemStacks.I guess, you should use
ItemStack.areItemStacksEqual()
instead of this and this.Please, change this mechanic to enable more complex MT recipes for Extreme Crafting table.
The text was updated successfully, but these errors were encountered: